Requesting Code Review
Requests code review after completing tasks or major features. Dispatches subagent to catch issues before merging, ensuring work meets requirements.
npx degit LangbaseInc/agent-skills/requesting-code-review my-requesting-review
- After completing a feature
- Before merging to main
- After significant refactoring
- When making architectural changes
- After bug fixes with tests
- When touching critical code
Code Quality
- Code follows style guidelines
- No linter warnings
- Functions are well-named
- Logic is clear and simple
- No commented-out code
- No debug statements
Testing
- All tests pass
- New tests added for new code
- Edge cases covered
- Test coverage maintained
Documentation
- Code comments for complex logic
- README updated if needed
- API docs updated
- CHANGELOG entry added
Git
- Commits are logical
- Commit messages are clear
- Branch is up to date with main
- No merge conflicts
Title
Clear, concise summary of changes
Description Template
## What
Brief description of the change
## Why
Reason for the change
## How
Technical approach taken
## Testing
How to test the changes
## Screenshots
For UI changes
## Checklist
- [ ] Tests pass
- [ ] Documentation updated
- [ ] No breaking changes
Before requesting review:
- Review your own code
- Check for obvious issues
- Run all tests locally
- Verify documentation
- Test manually
- Clean up debug code
Choose Reviewers
- Domain experts
- Code owners
- Team members who need context
- New team members for learning
Set Priority
- Urgent: Hotfixes, blockers
- Normal: Features, improvements
- Low: Refactoring, docs
Provide Context
- Link to related issues
- Explain design decisions
- Note areas needing special attention
- Mention known trade-offs
- Keep PRs small and focused
- One logical change per PR
- Provide clear description
- Respond to feedback promptly
- Be open to suggestions
- Thank reviewers
- Address all comments
- Request re-review after changes
Reviewers typically check:
- Code correctness
- Test coverage
- Performance implications
- Security concerns
- Edge cases
- Code style
- Documentation
- Breaking changes