Receiving Code Review

Handles code review feedback with technical rigor and verification. Requires understanding before implementing, asks clarifying questions, and evaluates suggestions against codebase reality.


npx degit LangbaseInc/agent-skills/receiving-code-review my-receiving-review

Understanding First

  • Read feedback thoroughly
  • Verify assumptions
  • Ask clarifying questions
  • Understand the "why" behind suggestions

Technical Rigor

  • Evaluate against codebase reality
  • Consider edge cases
  • Assess impact on existing code
  • Test changes thoroughly

Professional Communication

  • Thank reviewers
  • Explain reasoning
  • Discuss trade-offs
  • Seek consensus when needed

1. Review Feedback

  • Read all comments
  • Identify blocking issues
  • Categorize feedback types
  • Prioritize changes

2. Clarify

  • Ask questions when unclear
  • Verify understanding
  • Discuss alternatives
  • Seek examples if needed

3. Evaluate

  • Check against codebase
  • Consider implications
  • Assess feasibility
  • Identify dependencies

4. Implement

  • Make requested changes
  • Add tests
  • Update documentation
  • Verify fixes

5. Respond

  • Mark resolved
  • Explain approach
  • Note trade-offs
  • Request re-review

Bugs

  • Understand root cause
  • Fix properly, not superficially
  • Add regression tests
  • Document if non-obvious

Style/Convention

  • Follow project standards
  • Apply consistently
  • Use linter rules
  • Document exceptions

Architecture/Design

  • Understand concerns
  • Discuss alternatives
  • Consider future impact
  • Seek team consensus

Performance

  • Verify claims with data
  • Benchmark if needed
  • Consider trade-offs
  • Document decisions

  • Assume positive intent
  • Don't take feedback personally
  • Learn from every review
  • Ask questions freely
  • Explain your reasoning
  • Be open to better approaches
  • Test changes thoroughly
  • Keep discussions professional

  • "Thanks for catching that"
  • "Could you clarify what you mean by..."
  • "I considered X because..."
  • "Good point, I'll change it to..."
  • "What if we instead..."